This repository was archived by the owner on May 3, 2024. It is now read-only.
Automate patching composer-env.nix in update.sh#69
Open
charmoniumQ wants to merge 1 commit intotimhae:mainfrom
Open
Automate patching composer-env.nix in update.sh#69charmoniumQ wants to merge 1 commit intotimhae:mainfrom
charmoniumQ wants to merge 1 commit intotimhae:mainfrom
Conversation
Owner
|
there was a recent addition to the nixpkgs builders, namely buildComposerProject, which will make packaging easier but also require to add the env file in an overlay, I wanted to tackle that at some point.. See here for reference |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
composer-env.nixhas to be patched because we need to somehow set theAPP_KEYin order to continue with installation. This PR automatically patchescomposer-env.nixwithsed. It also introduces more debugging output for debugging the script.